On Oct. 22, 2007, 21:35 +0200, Matthew Wilcox <matthew@xxxxxx> wrote: > On Mon, Oct 22, 2007 at 09:10:49PM +0200, Boaz Harrosh wrote: >> I'm about to finish an RFC patchset for the extended commands. >> I have implemented a more aggressive approach than the one >> I've been sending for the last year. >> (Matthew I have an extra 8-bytes save to scsi_cmnd on >> 64bit and 12 bytes for 32bit. Guess how? ;)) > > Well ... the command has to be stored somewhere. If it's an additional > kmalloc, that's a loss. If it's in the request, that's a loss too ... > let's see where you're keeping it ;-) > I love spoiling Boaz's surprise :) The gist of it is scsi_cmnd->cmnd pointing at req->cmd or at req->varlen_cmd as appropriate. Most users can't tell the difference except if they tried using sizeof(scsi_cmnd->cmnd) in which case they can use MAX_COMMAND_SIZE instead. Benny - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
