Re: [PATCH 3/4] qla1280,qla2xxx: Remove display of transfersize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Matthew Wilcox wrote:
> On Thu, Oct 18, 2007 at 11:57:33AM -0700, Seokmann Ju wrote:
>> Matthew Wilcox wrote:
>>> As part of their debug routines, both of these drivers print out the
>>> transfersize.  That's just unnecessary, particularly since neither driver
>>> actually uses it.
>> NACK for qla2xxx - I would rather change it to 'cmd->device->sector_size' instead of removing it.
>> A patch will be followed by.
> 
> I don't understand why you care to print it at this point.  If you know
> the device, you know the sector size, right?
As the debug message doesn't get displayed in normal situation, just wanted to keep as many information in the function as possible.

Acked-by: Seokmann Ju <seokmann.ju@xxxxxxxxxx>

Thank you,
Seokmann

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux