Re: [PATCH v4] scsi: ufs: critical health condition

[Bart Van Assche <bvanassche@xxxxxxx>]

On 2/10/25 10:58 PM, Avri Altman wrote:
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> index cd404ade48dc..ef56a5eb52dc 100644
> --- a/drivers/ufs/core/ufshcd.c
> +++ b/drivers/ufs/core/ufshcd.c
> @@ -6216,6 +6216,11 @@ static void ufshcd_exception_event_handler(struct work_struct *work)
>   	if (status & hba->ee_drv_mask & MASK_EE_URGENT_TEMP)
>   		ufshcd_temp_exception_event_handler(hba, status);
>   
> +	if (status & hba->ee_drv_mask & MASK_EE_HEALTH_CRITICAL) {
> +		hba->critical_health_count++;
> +		sysfs_notify(&hba->dev->kobj, NULL, "critical_health");
> +	}
> +
>   	ufs_debugfs_exception_event(hba, status);
>   }

Hi Avri,

sysfs_notify() may sleep and hence must not be called from an interrupt
handler. Please fix.

Thanks,

Bart.