Hi Bart, On 13. Mar 2025, at 17:25, Bart Van Assche wrote: > On 3/13/25 7:25 AM, Thorsten Blum wrote: >> Remove hard-coded strings by using the str_on_off() helper function. > > Shouldn't a patch description explain two things: what has been changed > and also why a change has been made? I don't see an explanation of why > this change has been made. The benefits are explained in linux/string_choices.h and I didn't think it would be necessary to repeat them in the commit message: /* * Here provide a series of helpers in the str_$TRUE_$FALSE format (you can * also expand some helpers as needed), where $TRUE and $FALSE are their * corresponding literal strings. These helpers can be used in the printing * and also in other places where constant strings are required. Using these * helpers offers the following benefits: * 1) Reducing the hardcoding of strings, which makes the code more elegant * through these simple literal-meaning helpers. * 2) Unifying the output, which prevents the same string from being printed * in various forms, such as enable/disable, enabled/disabled, en/dis. * 3) Deduping by the linker, which results in a smaller binary file. */ Thanks, Thorsten
