Hi Bart, Thanks for the review feedback. On Fri, 28 Feb 2025 at 19:18, Bart Van Assche <bvanassche@xxxxxxx> wrote: > > On 2/26/25 2:04 PM, Peter Griffin wrote: > > - hci_writel(ufs, ilog2(DATA_UNIT_SIZE), HCI_TXPRDT_ENTRY_SIZE); > > + > > + if (hba->caps & UFSHCD_CAP_CRYPTO) > > + val |= PRDT_PREFECT_EN; > > In a future patch series, please consider renaming PRDT_PREFECT_EN into > PRDT_PREFECTH_EN. I was just checking the datasheet naming (it is listed as PRDT_PREFETCH_ENABLE). As well as the typo in my patch I think your reply also has a typo :) I'm assuming you would like it renamed to PRDT_PREFETCH_EN? Thanks, Peter