On Saturday, March 1, 2025 3:29 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > > On Fri, Feb 28, 2025 at 05:37:12PM -0800, Karan Tilak Kumar wrote: > > Remove unnecessary locking and unlocking of spinlock in > > fdls_schedule_oxid_free_retry_work. > > This will shorten the time in the critical section. > > > > Suggested-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > Fixes: a63e78eb2b0f ("scsi: fnic: Add support for fabric based solicited requests and responses") > > Reviewed-by: Sesidhar Baddela <sebaddel@xxxxxxxxx> > > Reviewed-by: Arulprabhu Ponnusamy <arulponn@xxxxxxxxx> > > Reviewed-by: Gian Carlo Boffa <gcboffa@xxxxxxxxx> > > Reviewed-by: Arun Easi <aeasi@xxxxxxxxx> > > Tested-by: Karan Tilak Kumar <kartilak@xxxxxxxxx> > > Signed-off-by: Karan Tilak Kumar <kartilak@xxxxxxxxx> > > --- > > Changes between v1 and v2: > > Incorporate review comments by Dan: > > Replace test and clear bit with clear bit. > > --- > > Thanks! > > I'm not really qualified to give a reviewed-by tag to this, but it looks > okay to me. > > regards, > dan carpenter > > Thanks for your review and comments, Dan. Appreciate your help. Regards, Karan