On Thu, Oct 18 2007 at 8:59 +0200, Benny Halevy <bhalevy@xxxxxxxxxxx> wrote: >> >> Updated patch below. I'm fully expecting the 'result' shenanigan to get >> it NACKed, but I'd like to see if it inspires anyone else to a more >> creative way of saving this space. > > > yeah. The sglist pointer shuffle makes sense and so are the field type > changes and coalescing, but the union holding the deprecated fields > of scsi_data_buff is going away. > > #pragma pack(4) before struct scsi_cmnd > (followed by #pragma pack()) should do the trick > by saving member padding bytes. As a general rule I don't like pragma's > but this one works, is easy to understand, and is pretty standard. > >> --- >> Sorry Matthew, my mistake I forgot to send the last [33/33] patch this here should be done on top of that last one. I will grab your tool and play with it. The sglist pointer shuffle is good, and also I know that if you put the scsi_data_buffer at the beginning of scsi_cmnd, than you can fill the holes with small types following the sub-structure. I'll give it a try. Boaz - To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
