Re: [PATCH v2] scsi: qedf: Use kcalloc() and add check for bdt_info

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Jiasheng Jiang <jiashengjiangcool@xxxxxxxxx>, linux-scsi@xxxxxxxxxxxxxxx, GR-QLogic-Storage-Upstream@xxxxxxxxxxx, James Bottomley <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, Javed Hasan <jhasan@xxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Saurav Kashyap <skashyap@xxxxxxxxxxx>
Subject: Re: [PATCH v2] scsi: qedf: Use kcalloc() and add check for bdt_info
From: Markus Elfring <Markus.Elfring@xxxxxx>
Date: Sun, 2 Feb 2025 17:54:14 +0100
Cc: LKML <linux-kernel@xxxxxxxxxxxxxxx>, Arun Easi <arun.easi@xxxxxxxxxx>, Bart Van Assche <bvanassche@xxxxxxx>, Manish Rangankar <manish.rangankar@xxxxxxxxxx>, Nilesh Javali <nilesh.javali@xxxxxxxxxx>
In-reply-to: <20250131213516.7750-1-jiashengjiangcool@gmail.com>
Ui-outboundreport: notjunk:1;M01:P0:dTq8ydIxLnI=;+Be+5z4UYFTNXc92GYHZXVroZ6t Z1O8r+rbmPqsMi9H9hKEF5py9zcn4ABgbGyvxlkFYbjhnYU/s3zHFuaMCpjl0ibhiHE7mjQ7f /9giRB+oBsWZhAufgDrkCnehyXSgs9jzWPrGt2LCBRNGRDYzOMODCIajm3tmZky9fgfxIckIA c3oNOtL5s+abSm25rpPV6CZPYisbgyH5l4P7vN79QF0mHlMrYiazEcTVJ3b4j1Aq4IPLivUHI DC9P7vkrS9vK1f+6f3Tfmx1v/TYrRaveQLBEyg1906/UzTTWuL/FHRvLYqqYgH7Bvvl7AbVCl m942kJM3kvutcnawn1VNMrHNJrzpccD84mHw2BvbbHWyHKO3RrD/z8Y/Iy/cYdPpup58aHaiV 1spDslKB6BEXNBGdaUx2hDJqJf6ONcqztPwPvwbL/LW8PqguD3aGErGcRIVusK/eBe+kjRo+e /tVh7MOuHKS9wnZq+lypw84ezGxGH1QNDYY2yOc0OFxetm1/X92hjWKixuDvgr19s/BuJ0jqa 0mjEghEyoWdf2oOPutWaje/FAnfiHxAljOBng2RjNTuJSyNVgfrPPr0+djfFWR1S/ubhMG00W mTlm7CUybKJmYXxRvLIAIwCeUFuVfhJZapPAInPWfj76GbdHDkBRKvz+lhQusLMIbh+2Pfqpu Xkz7XoY8gXFhkjF9BLXziZr6lpBvPno851BQpWiri30Kw5RJGIXV4+q86RyaLx8nfYKXok+c4 L1VlykkIkfIH7+F0CWcAzC/8cXP7IefNFB+/uF3S1U+ktNxgl3sRJ6JXSJoGQUd4uXLr2aMx2 5Ny5fzqmMm7sKCh6uzBs0AYwgulwZRSEbhjGNwrQU2SuAsg8n/m/Eh2+ZSYQfYvmXLCU2u2WG dTIejTQxP9K7Buc0PVx4Oa0zoeeGkcIWEx2Quf+To199KRr1ApCPDLFanh21d6biTTp7O4K1F qZYsIdn+8SVrWaZzVt5c//sHf3E34wGwHViBIn3D5vx3hzL8P2HrsLKQ05B5wh/iLgVYirjik tj7XEQW1uO2uVPqZSoY5le0enc0nWEBg+4V3RY4GKFkm+IATI73qXCi4qf788w5Ty8Pve14Jo NOOHHwYOI8Dv13d8aTrch25EBsP6u3JjftwgQs8DVPgK8TuchCU4HkOUSqllYyJvVIo0BWDPT wJZLQXjmKPmRrOihC9s8ASv4wZqaNUx3nRSFDok4FuoRXuGQW0GD/ffp9exLFGlr4HowF18d5 h/RJSDNFzjscQ1mv++1UnmF6LPlRNeWLll4iIWbhri2QZUA9ThhIDzZ5TlTJxv/PDMuKZeOJh 4PRZxQbT0XeClNBRZ/rToj5u7xyqPTdOcyrgJ0c0Labj62WW/8wETeUwjT0cFM7bK2A
User-agent: Mozilla Thunderbird

…
> +++ b/drivers/scsi/qedf/qedf_io.c
…
@@ -254,9 +254,7 @@ struct qedf_cmd_mgr *qedf_cmd_mgr_alloc(struct qedf_ctx *qedf)
 	}

 	/* Allocate pool of io_bdts - one for each qedf_ioreq */
…
+	cmgr->io_bdt_pool = kcalloc(num_ios, sizeof(struct io_bdt *), GFP_KERNEL);
…

See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.13#n941

Regards,
Markus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Follow-Ups:
- Re: [PATCH v2] scsi: qedf: Use kcalloc() and add check for bdt_info
  - From: Jiasheng Jiang
- [PATCH] scsi: qedf: Replace kmalloc_array() with kcalloc()
  - From: Jiasheng Jiang
- [PATCH] scsi: qedf: Add check for bdt_info
  - From: Jiasheng Jiang
- [PATCH] Replace kmalloc_array() with kcalloc()
  - From: Jiasheng Jiang

References:
- [PATCH v2] scsi: qedf: Use kcalloc() and add check for bdt_info
  - From: Jiasheng Jiang

Prev by Date: [PATCH v2] scsi: target: Remove unnecessary null checking for bio allocation
Next by Date: [PATCH] Replace kmalloc_array() with kcalloc()
Previous by thread: Re: [PATCH v2] scsi: qedf: Use kcalloc() and add check for bdt_info
Next by thread: [PATCH] Replace kmalloc_array() with kcalloc()
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]