Re: [Bug 3680] sym53c8xx_2 SMP deadlock on driver load

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 17, 2007 at 11:44:08AM -0400, Tony Battersby wrote:
> In 2.4, include/linux/init.h has the following:
> 
> #ifndef MODULE
> #define __init          __attribute__ ((__section__ (".text.init")))
> #else
> #define __init
> #endif
> 
> So __init has an effect only if it is built-in.

Ah yes, you're right.

> Apparently 2.6 also
> discards __init sections in modules after loading, but 2.4 doesn't.  Of
> course, it is still a bug.
> 
> Do you want me to redo the patch with __init taken out?

It would be better. As a general rule of thumb, an __init function should
not be called from a non __init, otherwise it is very hard to track the
call path.

Thanks,
Willy

-
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]
  Powered by Linux