On Wed, Jan 29, 2025 at 10:45:25AM -0500, Rik van Riel wrote: > On Tue, 28 Jan 2025 21:35:18 -0800 > Christoph Hellwig <hch@xxxxxxxxxxxxx> wrote: > > > GFP_NOFS is never the right thing for block layer allocations. > > The right thing here is GFP_NOIO which is a superset of GFP_NOFS. > > Otherwise you could reproduce the same deadlock when using swap > > instead of a file system to reproduce basically the same deadlock. > > Duh, you are right of course! > > The fixed up patch with GFP_NOIO is below. Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
