On 1/28/2025 4:21 PM, Damien Le Moal wrote: > On 1/29/25 3:21 AM, Easwar Hariharan wrote: >> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced >> secs_to_jiffies(). As the value here is a multiple of 1000, use >> secs_to_jiffies() instead of msecs_to_jiffies to avoid the multiplication. >> >> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with >> the following Coccinelle rules: >> >> @depends on patch@ >> expression E; >> @@ >> >> -msecs_to_jiffies >> +secs_to_jiffies >> (E >> - * \( 1000 \| MSEC_PER_SEC \) >> ) >> >> Signed-off-by: Easwar Hariharan <eahariha@xxxxxxxxxxxxxxxxxxx> > > The subject line should be: > > ata: libata-zpodd: convert timeouts to secs_to_jiffies() > > Other than that, looks good to me. > > Acked-by: Damien Le Moal <dlemoal@xxxxxxxxxx> > Thanks for the review and ack! I'll fix the subject line in v2. - Easwar (he/him)