Re: [RFC PATCH 2/6] scsi: scsi_debug: Add READ BLOCK LIMITS and modify LOAD for tapes

[Bart Van Assche <bvanassche@xxxxxxx>]

On 1/28/25 6:22 AM, Kai Mäkisara wrote:
> +#define SDEBUG_READ_BLOCK_LIMITS_ARR_SZ 6

Isn't enum or 'static const' preferred for declaring constants that are 
only used inside a single function?

> +	unsigned char arr[SDEBUG_READ_BLOCK_LIMITS_ARR_SZ];
> +
> +	memset(arr, 0, SDEBUG_READ_BLOCK_LIMITS_ARR_SZ);

The above two statements can be combined in a single statement:

	u8 arr[SDEBUG_READ_BLOCK_LIMITS_ARR_SZ] = { };

Thanks,

Bart.