RE: [PATCH] scsi: storvsc: Set correct data length for sending SCSI command without payload

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Long Li <longli@xxxxxxxxxxxxx>
> 
> > > SCSI mid layer may send commands to lower driver without initializing private
> > data.
> > > For example, scsi_send_eh_cmnd() may send TEST_UNIT_READY and
> > > REQUEST_SENSE to lower layer driver without initializing private data.
> >
> > Right. Thanks for pointing out this path that I wasn't aware of. My suggestion
> > would be to add a little more detail in the commit message, including identifying
> > this path where the private data isn't zero'ed. Some future developer will wonder
> > what's going on and appreciate having the specific reason provided.
> 
> I sent v2 adding more details to the comment.
> 

Thanks.  Looks good to me.

Michael






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux