Re: [PATCH] scsi: ufs: Move clock gating sysfs entries to ufs-sysfs.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 1/22/25 6:36 AM, Avri Altman wrote:
+static ssize_t
+clkgate_enable_show(struct device *dev, struct device_attribute *attr,
+		    char *buf)
+{

The above formatting does not conform to the Linux kernel coding style. Please fix this, e.g. by running git clang-format HEAD^ && git commit --amend on the git branch with this patch.

+	if (kstrtou32(buf, 0, &value))
+		return -EINVAL;
+
+	value = !!value;

Please use kstrtobool() instead of the above code.

Thanks,

Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux