+ Ziqi On Wed, Jan 22, 2025 at 04:36:05PM +0200, Avri Altman wrote: > This commit moves the clock gating sysfs entries from `ufshcd.c` to > `ufs-sysfs.c` where it belongs. This change improves the organization of > the code by consolidating all sysfs-related code into a single file. > > The `clkgate_enable` and `clkgate_delay_ms` attributes are now defined > and managed in `ufs-sysfs.c`, and the corresponding initialization and > removal functions in `ufshcd.c` are removed. > > No functional change. > > Signed-off-by: Avri Altman <avri.altman@xxxxxxx> While this patch is useful, you should also consider adding the ABI documentation for these. I did share the comment to another patch that touches this part of the code: https://lore.kernel.org/linux-scsi/20250119074823.lnlppdpsfnkz7onx@thinkpad/ Maybe it is relevant to add the documentation together with this patch. - Mani -- மணிவண்ணன் சதாசிவம்
