On 1/7/25 12:31 PM, Nilay Shroff wrote: > > > On 1/7/25 12:00 PM, Christoph Hellwig wrote: >> queue_limits_commit_update is the function that needs to operate on a >> frozen queue, not queue_limits_start_update. Update the kerneldoc >> comments to reflect that. >> >> Signed-off-by: Christoph Hellwig <hch@xxxxxx> >> --- >> block/blk-settings.c | 3 ++- >> include/linux/blkdev.h | 3 +-- >> 2 files changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/block/blk-settings.c b/block/blk-settings.c >> index 8f09e33f41f6..b6b8c580d018 100644 >> --- a/block/blk-settings.c >> +++ b/block/blk-settings.c >> @@ -413,7 +413,8 @@ int blk_set_default_limits(struct queue_limits *lim) >> * @lim: limits to apply >> * >> * Apply the limits in @lim that were obtained from queue_limits_start_update() >> - * and updated by the caller to @q. >> + * and updated by the caller to @q. The caller must have frozen the queue or >> + * ensure that there are outstanding I/Os by other means. > > Maybe typo: "ensure that there are *NO* outstanding I/Os by other means" Other than typo, everything else looks good. Once the above typo is fixed, please feel free to add: Reviewed-by: Nilay Shroff <nilay@xxxxxxxxxxxxx>
