On 2024/12/24 04:39, Jonathan Cameron wrote: > There is a subtle difference. In theory old code could dereference a NULL > if parent->p == NULL, now it can't. Sounds at most like a harmless change but > maybe you should mention it. > i did not correct parameter checking for device_find_child_by_name() in below commit https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/drivers/base/core.c?id=903c44939abc02e2f3d6f2ad65fa090f7e5df5b6 since this commit will come finally, actually, this commit is the original motivation of this whole patch series. > Otherwise LGTM > Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>