[PING] drivers/scsi: remove dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

Is there any news of the patch? Your feedback is much appreciated.

Have a good day,
Ariel

On Friday, December 13, 2024 23:57 CET, Ariel Otilibili <ariel.otilibili-anieli@xxxxxxxxxx> wrote:

> * reported by Coverity ID 1602240
> * ldev_info is always true, therefore the branch statement is never called.
> 
> Fixes: 081ff398c56cc ("scsi: myrb: Add Mylex RAID controller (block interface)")
> Cc: Hannes Reinecke <hare@xxxxxxxxxx>
> Cc: "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>
> Cc: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
> Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@xxxxxxxxxx>
> ---
>  drivers/scsi/myrb.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/scsi/myrb.c b/drivers/scsi/myrb.c
> index 363d71189cfe..dc4bd422b601 100644
> --- a/drivers/scsi/myrb.c
> +++ b/drivers/scsi/myrb.c
> @@ -1627,8 +1627,6 @@ static int myrb_ldev_sdev_init(struct scsi_device *sdev)
>  	enum raid_level level;
>  
>  	ldev_info = cb->ldev_info_buf + ldev_num;
> -	if (!ldev_info)
> -		return -ENXIO;
>  
>  	sdev->hostdata = kzalloc(sizeof(*ldev_info), GFP_KERNEL);
>  	if (!sdev->hostdata)
> -- 
> 2.47.1
>






[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux