> > Currently, this does not cause any issues, but I believe it is necessary to set > bsg_queue to NULL after removing it to prevent potential use-after-free (UAF) > access. OK. > > Signed-off-by: Guixin Liu <kanie@xxxxxxxxxxxxxxxxx> Reviewed-by: Avri Altman <avri.altman@xxxxxxx> > --- > drivers/ufs/core/ufs_bsg.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/ufs/core/ufs_bsg.c b/drivers/ufs/core/ufs_bsg.c index > 58023f735c19..8d4ad0a3f2cf 100644 > --- a/drivers/ufs/core/ufs_bsg.c > +++ b/drivers/ufs/core/ufs_bsg.c > @@ -216,6 +216,7 @@ void ufs_bsg_remove(struct ufs_hba *hba) > return; > > bsg_remove_queue(hba->bsg_queue); > + hba->bsg_queue = NULL; > > device_del(bsg_dev); > put_device(bsg_dev); > -- > 2.43.0
