Re: [GIT PULL] SCSI fixes for 6.13-rc2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 14 Dec 2024 at 15:08, James Bottomley
<James.Bottomley@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
>       scsi: ufs: core: Update compl_time_stamp_local_clock after completing a cqe

Why does that ufs driver have that pointless "local_clock" version,
when it also does a real ktime?

It's documented to be just for debugging.

Then the "ktime" version is documented to be for statistics.

What makes this all make sense? Two different clocks, for two
different non-essential uses? And that duplication literally causes
bugs because clearly people get confused.

This particular bug has been around for almost two years, so equally
clearly these timestamps really *really* aren't that important.

Can we just agree that it's silly *and* confusing to maintain two
different completely unimportant timestamps in parallel, and just get
rid of at least one of them?

            Linus




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux