On Thu, Nov 21, 2024 at 09:01:49AM +0000, John Garry wrote: > > --- a/drivers/virtio/virtio.c > > +++ b/drivers/virtio/virtio.c > > @@ -377,6 +377,24 @@ static void virtio_dev_remove(struct device *_d) > > of_node_put(dev->dev.of_node); > > } > > +/** > > nit: does this really need to be kerneldoc, as it is static? No, it's not necessary, I didn't know what the rules for static functions are. I'll update it accordingly.