On 14/11/2024 12:06, Daniel Wagner wrote:
On Thu, Nov 14, 2024 at 05:12:22PM +0800, Ming Lei wrote:
I feel driver should get higher priority, but in the probe() example,
call_driver_probe() actually tries bus->probe() first.
But looks not an issue for this patchset since only hisi_sas_v2_driver(platform_driver)
defines ->irq_get_affinity(), but the platform_bus_type doesn't have
the callback.
Oh, I was not aware of this ordering. And after digging this up here:
https://urldefense.com/v3/__https://lore.kernel.org/
all/20060105142951.13.01@xxxxxxxxxxxxxxxxxxxxxx/__;!!ACWV5N9M2RV99hQ!
IWDpRwKfvo0y1LzokS_0YDXzX7eZLeVUcaTOFCpn0yEcV2e5gknO2Q3igMwPhA1Mhq6IOKBOkiLxHYe-0sM$
I don't think we it's worthwhile to add the callback to device_driver
just for hisi_sas_v2. So I am going to drop this part again.
I agree. I would not add anything new to core code just for that driver.