On Wed, 2024-11-06 at 10:10 -0800, Bart Van Assche wrote: > Some early UFSHCI 4.0 controllers support the UFSHCI 3.0 register > set. > The UFSHCD_QUIRK_BROKEN_LSDBS_CAP quirk must be set for these > controllers. > Commit b92e5937e352 ("scsi: ufs: core: Move code out of an if- > statement") > changed the behavior for these controllers from working fine into > "ufshcd_add_scsi_host: failed to initialize (legacy doorbell mode not > supported)". Fix this by setting the "broken LSDBS" quirk for the > SM8650 development board. > > Reported-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > Closes: > https://lore.kernel.org/linux-scsi/0c0bc528-fdc2-4106-bc99-f23ae377f6f5@xxxxxxxxxx/ > Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8650-HDK > Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> # on SM8650-QRD > Fixes: b92e5937e352 ("scsi: ufs: core: Move code out of an if- > statement") > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> Appreciate it! Reviewed-by: Bean Huo <beanhuo@xxxxxxxxxx>