Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Thomas Weißschuh <linux@xxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()
From: "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>
Date: Mon, 04 Nov 2024 20:25:59 -0500
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, "Rafael J. Wysocki" <rafael@xxxxxxxxxx>, Bjorn Helgaas <bhelgaas@xxxxxxxxxx>, Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>, Davidlohr Bueso <dave@xxxxxxxxxxxx>, Jonathan Cameron <jonathan.cameron@xxxxxxxxxx>, Dave Jiang <dave.jiang@xxxxxxxxx>, Alison Schofield <alison.schofield@xxxxxxxxx>, Vishal Verma <vishal.l.verma@xxxxxxxxx>, Ira Weiny <ira.weiny@xxxxxxxxx>, Alex Deucher <alexander.deucher@xxxxxxx>, Christian König <christian.koenig@xxxxxxx>, Xinhui Pan <Xinhui.Pan@xxxxxxx>, David Airlie <airlied@xxxxxxxxx>, Simona Vetter <simona@xxxxxxxx>, Dennis Dalessandro <dennis.dalessandro@xxxxxxxxxxxxxxxxxxxx>, Jason Gunthorpe <jgg@xxxxxxxx>, Leon Romanovsky <leon@xxxxxxxxxx>, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>, Pratyush Yadav <pratyush@xxxxxxxxxx>, Michael Walle <mwalle@xxxxxxxxxx>, Miquel Raynal <miquel.raynal@xxxxxxxxxxx>, Richard Weinberger <richard@xxxxxx>, Vignesh Raghavendra <vigneshr@xxxxxx>, Naveen Krishna Chatradhi <naveenkrishna.chatradhi@xxxxxxx>, Carlos Bilbao <carlos.bilbao.osdev@xxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Ilpo Järvinen <ilpo.jarvinen@xxxxxxxxxxxxxxx>, "David E. Box" <david.e.box@xxxxxxxxxxxxxxx>, "James E.J. Bottomley" <James.Bottomley@xxxxxxxxxxxxxxxxxxxxx>, "Martin K. Petersen" <martin.petersen@xxxxxxxxxx>, Richard Henderson <richard.henderson@xxxxxxxxxx>, Matt Turner <mattst88@xxxxxxxxx>, Frederic Barrat <fbarrat@xxxxxxxxxxxxx>, Andrew Donnellan <ajd@xxxxxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Logan Gunthorpe <logang@xxxxxxxxxxxx>, "K. Y. Srinivasan" <kys@xxxxxxxxxxxxx>, Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>, Wei Liu <wei.liu@xxxxxxxxxx>, Dexuan Cui <decui@xxxxxxxxxxxxx>, Dan Williams <dan.j.williams@xxxxxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, linux-pci@xxxxxxxxxxxxxxx, linux-cxl@xxxxxxxxxxxxxxx, amd-gfx@xxxxxxxxxxxxxxxxxxxxx, dri-devel@xxxxxxxxxxxxxxxxxxxxx, linux-rdma@xxxxxxxxxxxxxxx, linux-mtd@xxxxxxxxxxxxxxxxxxx, platform-driver-x86@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, linux-alpha@xxxxxxxxxxxxxxx, linuxppc-dev@xxxxxxxxxxxxxxxx, linux-hyperv@xxxxxxxxxxxxxxx
In-reply-to: <20241103-sysfs-const-bin_attr-v2-5-71110628844c@weissschuh.net> ("Thomas Weißschuh"'s message of "Sun, 03 Nov 2024 17:03:34 +0000")
Organization: Oracle Corporation

Thomas,

> The is_bin_visible() callbacks should not modify the struct
> bin_attribute passed as argument. Enforce this by marking the argument
> as const.
>
> As there are not many callback implementers perform this change
> throughout the tree at once.

For scsi:

Acked-by: Martin K. Petersen <martin.petersen@xxxxxxxxxx>

-- 
Martin K. Petersen	Oracle Linux Engineering

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

References:
- [PATCH v2 00/10] sysfs: constify struct bin_attribute (Part 1)
  - From: Thomas Weißschuh
- [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()
  - From: Thomas Weißschuh

Prev by Date: [Bug 219467] Adaptec 71605 hangs with aacraid: Host adapter abort request after update to linux 6.11.5
Next by Date: Re: [PATCH v3 18/18] scsi: target: iscsi: switch to using the crc32c library
Previous by thread: Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()
Next by thread: Re: [PATCH v2 05/10] sysfs: treewide: constify attribute callback of bin_is_visible()
Index(es):
- Date
- Thread

[Index of Archives] [SCSI Target Devel] [Linux SCSI Target Infrastructure] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Linux IIO] [Samba] [Device Mapper]