Re: [PATCH v3] ufs: core: Add WB buffer resize support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 11/1/24 2:37 AM, Huan Tang wrote:
For the three new attributes: please use words in sysfs instead of
numbers. Using numbers is not user-friendly.


Hi Bart

Thank you for your reply!
Thanks for your suggestions

I am confused about the above sentence and I don't understand it. Can you give me more detailed guidance?

v4
https://lore.kernel.org/all/20241101093318.825-1-tanghuan@xxxxxxxx/

Hi Huan,

Please modify the implementation of sysfs attributes like
wb_toggle_buf_resize such that a string is accepted (e.g. increase, decrease) instead of numbers (1, 2).

See also how sysfs_match_string() is used in e.g. drivers/scsi/sd.c.
Several sd sysfs attributes support writing a string into sysfs
attributes and that string is translated into a number.

Thanks,

Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux