> > > On 10/28/24 1:04 PM, Bean Huo wrote: > > > > Even though I don't think it's necessary to enable a Sysfs node > > > > entry for this configuration. > > > > > > Right, a motivation of why this functionality should be available in > > > sysfs is missing. An explanation should be added in the patch > > > description. > > > > > > Thanks, > > > > > > Bart. > > > > Hi Bean & Bart, > > > > Motivation: Through the sysfs upper layer code, the WB resize function > > can be used in some scenarios, or related information can be obtained > > indirectly to implement different strategies; What is your suggestion? > > sysfs? exception event? or? > > > > Thanks > > Huan > > hey Huan, > > What specific scenarios would require enabling a sysfs node to control this function? Dynamically > adjusting the WriteBooster (WB) size on the fly doesnâ??t seem ideal to me. From my perspective, the main > case for this feature is if the OEM didnâ??t correctly define or set the WriteBooster Buffer size during > manufacturing. Even then, adjusting the WB buffer size wouldnâ??t be a frequent need. If JEDEC has > found a reason for this feature to be accepted, isnâ??t there already an interface available to configure it? > Why would we need a duplicate interface for the same purpose? > > Kind regards, > Bean Hi Bean, Thanks for your reply The scenario I'm thinking of right nowï¼? when the old phone transfers a large amount of data to the new phone's APP (vivo calls it easyshare APP), we can explicitly resize the WB buffer. Could you please explain this sentence(If JEDEC has found a reason for this feature to be accepted, isnâ??t there already an interface available to configure it? Why would we need a duplicate interface for the same purpose?) more simply so I can understand it better? JEDEC draft comments: The WriteBooster buffer size can be resized in preserve user space configuration mode of WriteBooster by device implicitly. However, the disadvantage of preserve user space mode of WriteBooster configuration is that there could be performance degradation when the physical storage used for the WriteBooster Buffer is returned to user space, since the device has to make internal data structure adjustments as well as flush the WriteBooster Buffer data. To minimize this disadvantage, the WriteBooster Resize command is provided. The device only provides hint information to the host whether the WriteBooster Buffer needs to be resized or not, and the host can execute the WriteBooster Resize command based on this hint information when there is no user IOs Thanks Huan
