On 10/24/24 00:25, Bart Van Assche wrote:
> On 10/23/24 3:17 PM, Mirsad Todorovac wrote:
>> Fixes: 21038b0900d1b ("scsi: qla2xxx: Fix endianness annotations in header files")
>
> The "Fixes:" tag is wrong. The one-element arrays were introduced long
> before I fixed the endianness annotations.
>
>> diff --git a/drivers/scsi/qla2xxx/qla_dbg.h b/drivers/scsi/qla2xxx/qla_dbg.h
>> index 54f0a412226f..ca9304df484b 100644
>> --- a/drivers/scsi/qla2xxx/qla_dbg.h
>> +++ b/drivers/scsi/qla2xxx/qla_dbg.h
>> @@ -31,7 +31,7 @@ struct qla2300_fw_dump {
>> __be16 fpm_b1_reg[64];
>> __be16 risc_ram[0xf800];
>> __be16 stack_ram[0x1000];
>> - __be16 data_ram[1];
>> + __be16 data_ram[];
>> };
>>
>
> How has this patch been tested? Has it even been compile-tested? This
> patch probably breaks at least the following statement:
>
> BUILD_BUG_ON(sizeof(struct qla2300_fw_dump) != 136100);
>
> Thanks,
>
> Bart.
