Re: [PATCH 3/7] scsi: ufs: core: Simplify ufshcd_try_to_abort_task()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2024-10-16 at 14:11 -0700, Bart Van Assche wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  The MCQ code is also valid for legacy mode. Hence, remove the legacy
> mode code and retain the MCQ code. Since it is not an error if a
> command
> completes while ufshcd_try_to_abort_task() is in progress, use
> dev_info()
> instead of dev_err() to report this.
> 
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
>  drivers/ufs/core/ufshcd.c | 32 ++++++++------------------------
>  1 file changed, 8 insertions(+), 24 deletions(-)
> 
> diff --git a/drivers/ufs/core/ufshcd.c b/drivers/ufs/core/ufshcd.c
> 

Hi Bart,

As the DBR clear event occurs before !ufshcd_cmd_inflight, 
this could potentially cause an additional usleep_range wait. 
If an additional wait of 100~200 us is not a concern, then 
I think it should be fine.

Thanks
Peter




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux