On 10/18/24 10:25 AM, Avri Altman wrote:
On 10/17/24 10:50 PM, Avri Altman wrote:
Use blk_mq_quiesce_tagset() / blk_mq_unquiesce_tagset() instead of
scsi_block_requests() / scsi_unblock_requests() because the former
wait for ongoing SCSI command dispatching to finish while the latter do
not.
Fixes: 2e3611e9546c ("scsi: ufs: fix exception event handling")
>
I think that when Maya introduced the scsi_block_requests calls
(2018), the block tagset quiesce api wasn't available yet (2022).
Hi Avri,
Do you perhaps want me to integrate that information in the patch
description?
>
No. But the Fixes tag seems strange, isn't it?
Right, that patch did not introduce the issue that
ufshcd_exception_event_handler() doesn't wait for ongoing SCSI command
dispatching calls. Let me look up which patch introduced that issue.
Thanks,
Bart.