> > On 10/17/24 11:07 AM, Avri Altman wrote: > > I was just pointing out that after your change, the extra info of RTC > > will no longer be available, And proposed a way in which we can still retain > it. > > Something like this change? > > diff --git a/drivers/ufs/core/ufs-mcq.c b/drivers/ufs/core/ufs-mcq.c index > 57ced1729b73..988400500560 100644 > --- a/drivers/ufs/core/ufs-mcq.c > +++ b/drivers/ufs/core/ufs-mcq.c > @@ -572,14 +572,18 @@ int ufshcd_mcq_sq_cleanup(struct ufs_hba *hba, > int > task_tag) > /* SQRTCy.ICU = 1 */ > writel(SQ_ICU, opr_sqd_base + REG_SQRTC); > > - /* Poll SQRTSy.CUS = 1. Return result from SQRTSy.RTC */ > + /* Wait until SQRTSy.CUS = 1. Report SQRTSy.RTC. */ > reg = opr_sqd_base + REG_SQRTS; > err = read_poll_timeout(readl, val, val & SQ_CUS, 20, > MCQ_POLL_US, false, reg); > if (err) > - dev_err(hba->dev, "%s: failed. hwq=%d, tag=%d err=%ld\n", > - __func__, id, task_tag, > - FIELD_GET(SQ_ICU_ERR_CODE_MASK, readl(reg))); > + dev_err(hba->dev, "%s: failed. hwq=%d, tag=%d err=%d\n", > + __func__, id, task_tag, err); > + else > + dev_info(hba->dev, > + "%s, hwq %d: cleanup return code (RTC) %ld\n", > + __func__, id, > + FIELD_GET(SQ_ICU_ERR_CODE_MASK, readl(reg))); Yes. Thanks, Avri > > if (ufshcd_mcq_sq_start(hba, hwq)) > err = -ETIMEDOUT; > > Thanks, > > Bart.