Re: [PATCH 2/4] scsi: Convert SCSI drivers to .device_configure()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/1/24 05:18, Bart Van Assche wrote:
> There is agreement that the word "slave" should not be used in Linux
> kernel source code. Hence this patch that converts all SCSI drivers from
> .slave_configure() to .device_configure(). No functionality has been
> changed.n
> 
> Cc: Damien Le Moal <dlemoal@xxxxxxxxxx>
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> ---
>  drivers/scsi/ps3rom.c                       |  5 +++--
>  47 files changed, 166 insertions(+), 124 deletions(-)
> 
> diff --git a/drivers/scsi/ps3rom.c b/drivers/scsi/ps3rom.c
> index 90495a832f34..dcf911d68cf8 100644
> --- a/drivers/scsi/ps3rom.c
> +++ b/drivers/scsi/ps3rom.c
> @@ -61,7 +61,8 @@ enum lv1_atapi_in_out {
>  };
>  
>  
> -static int ps3rom_slave_configure(struct scsi_device *scsi_dev)
> +static int ps3rom_device_configure(struct scsi_device *scsi_dev,
> +				   struct queue_limits *lim)
>  {
>  	struct ps3rom_private *priv = shost_priv(scsi_dev->host);
>  	struct ps3_storage_device *dev = priv->dev;
> @@ -325,7 +326,7 @@ static irqreturn_t ps3rom_interrupt(int irq, void *data)
>  
>  static const struct scsi_host_template ps3rom_host_template = {
>  	.name =			DEVICE_NAME,
> -	.slave_configure =	ps3rom_slave_configure,
> +	.device_configure =	ps3rom_device_configure,
>  	.queuecommand =		ps3rom_queuecommand,
>  	.can_queue =		1,
>  	.this_id =		7,

Looks good for ps3rom. Thanks for your fixes.

Acked-by: Geoff Levand <geoff@xxxxxxxxxxxxx>





[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux