On Fri, 2024-09-20 at 12:36 -0700, Bart Van Assche wrote: > > External email : Please do not click links or open attachments until > you have verified the sender or the content. > On 9/20/24 2:06 AM, peter.wang@xxxxxxxxxxxx wrote: > > This series fixes MCQ and SDB abort defect. > > Hi Peter, > > Patches 2, 3 and 4 in this series introduce a significant amount of > complexity. Additionally, code paths are introduced that can only be > triggered by UFS controllers that (incorrectly) generate a completion > interrupt for aborted commands. I'm concerned that these patches will > make the UFS host controller driver harder to maintain than > necessary. > Please take another look at the approach I proposed, namely making > ufshcd_compl_one_cqe() ignore commands with completion status > OCS_ABORTED. I think this approach will result in a simpler > implementation, does not require a new quirk and minimizes the code > paths that are only triggered by UFS host controllers that trigger a > completion interrupt for aborted commands. > > Thanks, > > Bart. Hi Bart, Because I feel it's a bit weird to intentionally ignore a CQ slot in MCQ mode and directly requeue, but I will try to make changes according to your idea. Thanks. Peter
