Re: [PATCH v5 04/10] scsi: ufs: core: Introduce ufshcd_process_device_init_result()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Bart,

kernel test robot noticed the following build warnings:

[auto build test WARNING on mkp-scsi/for-next]
[cannot apply to jejb-scsi/for-next linus/master v6.11-rc7 next-20240913]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/scsi-ufs-core-Introduce-ufshcd_add_scsi_host/20240911-055406
base:   https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
patch link:    https://lore.kernel.org/r/20240910215139.3352387-5-bvanassche%40acm.org
patch subject: [PATCH v5 04/10] scsi: ufs: core: Introduce ufshcd_process_device_init_result()
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20240914/202409140417.VXgks1dM-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240914/202409140417.VXgks1dM-lkp@xxxxxxxxx/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202409140417.VXgks1dM-lkp@xxxxxxxxx/

All warnings (new ones prefixed by >>):

>> drivers/ufs/core/ufshcd.c:7675: warning: Function parameter or struct member 'device_init_start' not described in 'ufshcd_process_device_init_result'
>> drivers/ufs/core/ufshcd.c:7675: warning: Excess function parameter 'start' description in 'ufshcd_process_device_init_result'


vim +7675 drivers/ufs/core/ufshcd.c

  7666	
  7667	/**
  7668	 * ufshcd_process_device_init_result - Process the ufshcd_device_init() result.
  7669	 * @hba: UFS host controller instance.
  7670	 * @start: time when the ufshcd_device_init() call started.
  7671	 * @ret: ufshcd_device_init() return value.
  7672	 */
  7673	static void ufshcd_process_device_init_result(struct ufs_hba *hba,
  7674						ktime_t device_init_start, int ret)
> 7675	{
  7676		unsigned long flags;
  7677	
  7678		spin_lock_irqsave(hba->host->host_lock, flags);
  7679		if (ret)
  7680			hba->ufshcd_state = UFSHCD_STATE_ERROR;
  7681		else if (hba->ufshcd_state == UFSHCD_STATE_RESET)
  7682			hba->ufshcd_state = UFSHCD_STATE_OPERATIONAL;
  7683		spin_unlock_irqrestore(hba->host->host_lock, flags);
  7684	
  7685		trace_ufshcd_init(dev_name(hba->dev), ret,
  7686				ktime_to_us(ktime_sub(ktime_get(), device_init_start)),
  7687				hba->curr_dev_pwr_mode, hba->uic_link_state);
  7688	}
  7689	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux