Re: [PATCH v5 1/5] fs, block: refactor enum rw_hint

To: Kanchan Joshi <joshi.k@xxxxxxxxxxx>, Christoph Hellwig <hch@xxxxxx>
Subject: Re: [PATCH v5 1/5] fs, block: refactor enum rw_hint
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Thu, 12 Sep 2024 13:30:10 -0700
Cc: axboe@xxxxxxxxx, kbusch@xxxxxxxxxx, sagi@xxxxxxxxxxx, martin.petersen@xxxxxxxxxx, James.Bottomley@xxxxxxxxxxxxxxxxxxxxx, brauner@xxxxxxxxxx, viro@xxxxxxxxxxxxxxxxxx, jack@xxxxxxx, jaegeuk@xxxxxxxxxx, jlayton@xxxxxxxxxx, chuck.lever@xxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-f2fs-devel@xxxxxxxxxxxxxxxxxxxxx, linux-block@xxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, gost.dev@xxxxxxxxxxx, vishak.g@xxxxxxxxxxx, javier.gonz@xxxxxxxxxxx
In-reply-to: <0baddb91-b292-db90-8110-37fa5a19af01@samsung.com>
User-agent: Mozilla Thunderbird

On 9/12/24 8:50 AM, Kanchan Joshi wrote:

Wherever hint is being used in generic way, u8 data type is being used.


Has it been considered to introduce a new union and to use that as the
type of 'hint' instead of 'u8'?

Thanks,

Bart.

Follow-Ups:
- Re: [PATCH v5 1/5] fs, block: refactor enum rw_hint
  - From: Kanchan Joshi

References:
- [PATCH v5 0/5] data placement hints and FDP
  - From: Kanchan Joshi
- [PATCH v5 1/5] fs, block: refactor enum rw_hint
  - From: Kanchan Joshi
- Re: [PATCH v5 1/5] fs, block: refactor enum rw_hint
  - From: Christoph Hellwig
- Re: [PATCH v5 1/5] fs, block: refactor enum rw_hint
  - From: Kanchan Joshi