On Wed, Sep 11, 2024 at 05:23:26PM -0600, Keith Busch wrote: > On Wed, Sep 11, 2024 at 01:12:40PM -0700, Keith Busch wrote: > > @@ -102,6 +103,12 @@ int blk_rq_map_integrity_sg(struct request_queue *q, struct bio *bio, > > + */ > > + BUG_ON(segments > blk_rq_nr_phys_segments(rq)); > > Doh, this was mixed up with the copy from blk_rq_map_sg. It should say: > > BUG_ON(segments > blk_rq_nr_integrity_segments(rq)); > > Question though, blk_rq_map_sg uses WARN and scsi used BUG for this > check. But if the condition is true, a buffer overrun occured. So BUG, > right? That would be my preference, unless we manage to add a error return condition. Note that Linus seems to be on his weird anti-BUG crusade again, though.
