On Wed, Sep 11, 2024 at 01:12:35PM -0700, Keith Busch wrote: > +static inline int blk_rq_integrity_map_user(struct request *rq, void __user *ubuf, > + ssize_t bytes, u32 seed) Please avoid the overly long line here and maybe use normal two tab indents for the second line. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>