On Tue, Sep 10, 2024 at 05:30:46PM +0200, Christoph Hellwig wrote: > On Wed, Sep 04, 2024 at 08:25:57AM -0700, Keith Busch wrote: > > From: Keith Busch <kbusch@xxxxxxxxxx> > > > > This way drivers that want this value don't need to concern themselves > > with the CONFIG_BLK_DEV_INTEGRITY setting. > > Looks ok: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > Although I wonder if we should simply define the field unconditionally > given that it is only 2 bytes wide and packs nicely. Good idea, I didn't consider that. Various parts become cleaner if it's unconditionally part of the request. I'll try it out. BTW, just want to mention the the return value here is unreliable until patch 10. I've reworked the series so that appears first to avoid a bisect hazard. The end result is the same though, so I didn't want to spam the mailing list with a v2 just yet.
