Re: [PATCH v2 3/4] scsi: ufs: core: Always initialize the UIC done completion

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2024-09-09 at 16:11 -0700, Bart Van Assche wrote:
>  	 
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>  Simplify __ufshcd_send_uic_cmd() by always initializing the
> uic_cmd::done completion. This is fine since the time required to
> initialize a completion is small compared to the time required to
> process an UIC command.
> 
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>
> 

Hi Bart,

The time to compare should not be with the UIC command process time.
It should be compared with the time for the "if (completion)"
conditional 
expression. We cannot justify increasing the latency of sending a UIC 
command just because the UIC command process time is longer.

Thanks.
Peter




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux