On 9/6/24 4:59 PM, Bao D. Nguyen wrote:
In the original code, if UFSHCD_QUIRK_SKIP_PH_CONFIGURATION is set, ufshcd_device_init() would exit early. However, in this patch, if UFSHCD_QUIRK_SKIP_PH_CONFIGURATION is set, the new function ufshcd_activate_link() would return 0 which would cause the ufshcd_device_init() to continue further down. As a result, the ufshcd_device_init() would fail to handle the UFSHCD_QUIRK_SKIP_PH_CONFIGURATION flag as its original intention, right?
Hi Bao, I was assuming that UFSHCD_STATE_RESET != 0 but apparently it is zero. I will fix this patch before I repost this patch series. Thanks, Bart.