On 9/1/24 12:25 PM, Bean Huo wrote:
It's inconvenient to review them one by one, so until the last one. I
understand the main purpose is to remove init_dev_params. Why not merge
all the preparation patches into the last one?
The main purpose of this patch series is to combine the two
scsi_add_host() calls into a single call (see also the cover letter).
Something unfortunate about the current MCQ implementation is that
adding MCQ support introduced a new scsi_add_host() call far away from
the original scsi_add_host() call. Hence, there is a risk that the two
code paths for adding a SCSI host in the UFS driver would start to
diverge. This patch series eliminates that risk by combining the two
scsi_add_host() calls into a single call.
Removing the 'init_dev_params' argument is only a secondary goal of this
patch series.
I'm afraid if I would combine all nine patches into a single patch that
it would be very hard to review that single patch. Additionally, the
patch description would become very long. The kernel documentation says
the following about long patch descriptions: "If your description starts
to get long, that's a sign that you probably need to split up your
patch. See :ref:`split_changes`."
Thanks,
Bart.
