On Mon, Aug 26, 2024 at 11:05:47AM -0700, Bart Van Assche wrote: > On 8/25/24 11:25 PM, Dan Carpenter wrote: > > New smatch warnings: > > drivers/ufs/core/ufshcd.c:5484 ufshcd_uic_cmd_compl() error: we previously assumed 'cmd' could be null (see line 5474) > > This smatch warning is a false positive. There are multiple code blocks > in this functions that are guarded by if-statements. The two code blocks > this warning applies to are mutually exclusive. Hence, the 'cmd' check > from one block should not be used to draw conclusions about other code > blocks. I will consider to introduce the 'else' keyword to suppress this > false positive. I thought that might be the case, but I wasn't sure. If it's a false positive, then you can just ignore it. All old warnings are false positives. People can find this thread if they have questions. regards, dan carpenter
