On 8/22/24 8:42 AM, Bean Huo wrote:
On Thu, 2024-08-22 at 20:15 +0900, Kiwoong Kim wrote:
Kiwoong Kim (2):
scsi: ufs: core: introduce override_cqe_ocs
scsi: ufs: ufs-exynos: implement override_cqe_ocs
Hi Kiwoong Kim,
I didn't see your patch email,just post your second patch here, and
provide my comments:
+static enum utp_ocs exynos_ufs_override_cqe_ocs(enum utp_ocs ocs)
+{
+ if (ocs == OCS_ABORTED)
+ ocs = OCS_INVALID_COMMAND_STATUS;
+ return ocs;
+}
I wonder if you have considered the case where the command is aborted
by the host software or by the device itself?
If you change OCS to OCS_INVALID_COMMAND_STATUS, there will report a
DID_REQUEUE to SCSI.
The decision about what to do probably should depend on whether or not
the command has been nullified.
Thanks,
Bart.
