On Mon, Aug 19, 2024 at 12:24:42AM +0200, Mary Guillemard wrote: > MT8183 supports UFSHCI 2.1 spec, but report a bogus value of 1 in the > reserved part for the Legacy Single Doorbell Support (LSDBS) capability. > Wow... I never thought that this quirk will be used outside of Qcom SoCs... > This set UFSHCD_QUIRK_BROKEN_LSDBS_CAP when MCQ support is explicitly > disabled, allowing the device to be properly registered. > > Signed-off-by: Mary Guillemard <mary@xxxxxxxxx> > --- > drivers/ufs/host/ufs-mediatek.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c > index 02c9064284e1..9a5919434c4e 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c > @@ -1026,6 +1026,9 @@ static int ufs_mtk_init(struct ufs_hba *hba) > if (host->caps & UFS_MTK_CAP_DISABLE_AH8) > hba->caps |= UFSHCD_CAP_HIBERN8_WITH_CLK_GATING; > > + if (host->caps & UFS_MTK_CAP_DISABLE_MCQ) How can this be the deciding factor? You said above that the issue is with MT8183 SoC. So why not just use the quirk only for that platform? - Mani > + hba->quirks |= UFSHCD_QUIRK_BROKEN_LSDBS_CAP; > + > ufs_mtk_init_clocks(hba); > > /* > -- > 2.46.0 > > -- மணிவண்ணன் சதாசிவம்
