Re: [REGRESSION] critical target error, bisected

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Shinichiro,

> I guess SD_LBP_FULL would be more appropriate than SD_LBP_DISABLE,
> because the comment in drivers/scsi/sd.h says that SD_LBP_DISABLE
> indicates that "Discard disabled due to failed cmd".

> I confirmed that the fix patch avoids my failure both with
> SD_LBP_DISABLE and SD_LBP_FULL.

Yes, you are right. It is more appropriate to print "full" in sysfs when
LBMPE is disabled. Printing aside, the two modes are identical. I
switched the return to SDP_LBP_FULL.

-- 
Martin K. Petersen	Oracle Linux Engineering




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux