On Thu, Aug 15, 2024 at 07:19:50AM +0100, John Garry wrote: > static inline unsigned int bdev_write_zeroes_sectors(struct block_device > *bdev) > { > struct request_queue *q = bdev_get_queue(bdev); > > if (q) > return q->limits.max_write_zeroes_sectors; > > return 0; > } > > According to the comment in bdev_get_queue(), it never is never NULL. Probably because no one got around to remove it. There never was a need to check the return value, but lots of places did check it. I removed most of them as did a few others when touchign the code, but apparently we never got to this one.