On 7/23/24 09:49, Martin K. Petersen wrote: > > Yohan, > >> Add SPC version verification to avoid unnecessary inquiry command > > Are you experiencing an actual error condition as a result of this > INQUIRY operation? > > Devices often adopt new protocol features prior to the spec being > finalized. Therefore we generally use INQUIRY to discover capabilities > rather than relying on the reported spec compliance. > >> + /* Support for CPR was defined in SPC-5. */ >> + if (sdev->scsi_level < SCSI_SPC_5) >> + return; >> + > > I'm OK with the change but I'll defer to Damien as to whether this is an > acceptable heuristic. By the way, that may not be adequate as ATA devices that implement CPR may advertise an ACS version that does not translate to SPC-5, which is exactly the point you said. -- Damien Le Moal Western Digital Research
