RE: [PATCH 1/5] scsi: ufs: renesas: Refactor init code for other UFS controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Bart,

> From: Bart Van Assche, Sent: Tuesday, July 9, 2024 2:05 AM
> 
> On 7/8/24 5:09 AM, Yoshihiro Shimoda wrote:
> > +static void ufs_renesas_param_poll(struct ufs_hba *hba, u32 reg, u32 expected,
> > +				   u32 mask)
> > +{
> > +	struct ufs_renesas_init_param param = { 0 };
> > +
> > +	param.mode = MODE_POLL;
> > +	param.reg = reg;
> > +	param.u.expected = expected;
> > +	param.mask = mask;
> 
> Please combine the above declaration and assignments into a single
> statement:
> 
> struct ufs_renesas_init_param param = {
>          .mode = MODE_POLL,
>          .reg = reg,
>          .u.expected = expected,
>          .mask = mask,
> };
> 
> Same comment for the other functions below this function.

Thank you for your review! I got it. I'll fix them.

Best regards,
Yoshihiro Shimoda

> Thanks,
> 
> Bart.




[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Index of Archives]     [SCSI Target Devel]     [Linux SCSI Target Infrastructure]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Linux IIO]     [Samba]     [Device Mapper]

  Powered by Linux