On 01/07/2024 22:53, Damien Le Moal wrote:
The scsi disk message "Starting disk" to signal resuming of a suspended
disk is printed in both sd_resume() and sd_resume_common(), which
results in this message being printed twice when resuming from e.g.
autosuspend:
$ echo 5000 > /sys/block/sda/device/power/autosuspend_delay_ms
$ echo auto > /sys/block/sda/device/power/control
[ 4962.438293] sd 0:0:0:0: [sda] Synchronizing SCSI cache
[ 4962.501121] sd 0:0:0:0: [sda] Stopping disk
$ echo on > /sys/block/sda/device/power/control
[ 4972.805851] sd 0:0:0:0: [sda] Starting disk
[ 4980.558806] sd 0:0:0:0: [sda] Starting disk
Fix this double print by removing the call to sd_printk() from
sd_resume() and moving the call to sd_printk() in sd_resume_common()
earlier in the function, before the check using sd_do_start_stop().
Doing so, the message is printed once regardless if sd_resume_common()
actually executes sd_start_stop_device() (i.e. scsi device case) or not
(libsas and libata managed ATA devices case).
Fixes: 0c76106cb975 ("scsi: sd: Fix TCG OPAL unlock on system resume")
Cc:stable@xxxxxxxxxxxxxxx
Signed-off-by: Damien Le Moal<dlemoal@xxxxxxxxxx>
Reviewed-by: Bart Van Assche<bvanassche@xxxxxxx>
Reviewed-by: John Garry <john.g.garry@xxxxxxxxxx>
