> ufshcd_mcq_poll_cqe_lock() is declared in include/ufs/ufshcd.h and also in > drivers/ufs/core/ufshcd-priv.h. Remove the declaration from the latter file. Hi Bart, The functions below seem to be the same case. - ufshcd_mcq_write_cqis() - ufshcd_mcq_read_cqis() - ufshcd_mcq_config_mac() - ufshcd_mcq_make_queues_operational() How about including these cases in the patch as well? Best Regards, Keoseong > > Reviewed-by: Avri Altman <avri.altman@xxxxxxx> > Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx> > --- > drivers/ufs/core/ufshcd-priv.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/ufs/core/ufshcd-priv.h b/drivers/ufs/core/ufshcd-priv.h > index f42d99ce5bf1..0bce72848402 100644 > --- a/drivers/ufs/core/ufshcd-priv.h > +++ b/drivers/ufs/core/ufshcd-priv.h > @@ -72,8 +72,6 @@ u32 ufshcd_mcq_read_cqis(struct ufs_hba *hba, int i); > void ufshcd_mcq_write_cqis(struct ufs_hba *hba, u32 val, int i); > struct ufs_hw_queue *ufshcd_mcq_req_to_hwq(struct ufs_hba *hba, > struct request *req); > -unsigned long ufshcd_mcq_poll_cqe_lock(struct ufs_hba *hba, > - struct ufs_hw_queue *hwq); > void ufshcd_mcq_compl_all_cqes_lock(struct ufs_hba *hba, > struct ufs_hw_queue *hwq); > bool ufshcd_cmd_inflight(struct scsi_cmnd *cmd);
