Hi Prabhakar! > This patch series, generated using Coccinelle, aims to improve code > readability and maintainability by replacing ternary operations with > the min() and max() macros where applicable in the SCSI subsystem. Your proposed changes do not improve maintainability. They are creating additional maintenance work and making backports of bug fixes more difficult. Plus they introduce the potential for regressions of tried and true code. So the series has the opposite effect of what is claimed. Readability is in the eye of the beholder. Whether to use one approach or the other is the code author's choice... -- Martin K. Petersen Oracle Linux Engineering
